Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test:Increase [integration-tx-api] module test case coverage #6533

Open
wants to merge 14 commits into
base: 2.x
Choose a base branch
from
Open

test:Increase [integration-tx-api] module test case coverage #6533

wants to merge 14 commits into from

Conversation

azatyamanaev
Copy link

@azatyamanaev azatyamanaev commented May 12, 2024 •
edited

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

increase test case coverage of [integration-tx-api] module

Ⅱ. Does this pull request fix one issue?

fixes #6507

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@azatyamanaev azatyamanaev marked this pull request as ready for review May 13, 2024 15:50
@xingfudeshi xingfudeshi changed the title Increase [integration-tx-api] module test case coverage test:Increase [integration-tx-api] module test case coverage May 15, 2024
@xingfudeshi xingfudeshi self-requested a review May 15, 2024 09:33
@xingfudeshi
Copy link
Member

Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes

@azatyamanaev
Copy link
Author

Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes

@xingfudeshi Done

@azatyamanaev
Copy link
Author

@xingfudeshi Can you resolve merge conflict?

@xingfudeshi
Copy link
Member

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

@azatyamanaev
Copy link
Author

azatyamanaev commented May 20, 2024 •
edited

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

How long does it usually take?

@xingfudeshi
Copy link
Member

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

How long does it usually take?

It won’t take long. After version 2.1 is released, I will start addressing the conflicting files in this PR.

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingfudeshi xingfudeshi Awaiting requested review from xingfudeshi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
first-time contributor first-time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task: Improve the test case coverage of [integration-tx-api] module to 70%
2 participants
@azatyamanaev @xingfudeshi