Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35356][State] State descriptor and implementation for async reducing state #24798

Merged
merged 1 commit into from
May 17, 2024

Conversation

Zakelly
Copy link
Contributor

@Zakelly Zakelly commented May 16, 2024

What is the purpose of the change

This PR provides the definition of StateDescriptor and simple implementation for ReducingState in State V2.

Brief change log

  • Definition and tests for ReducingState and ReducingStateDescriptor

Verifying this change

Added UT for each new introduced class.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@Zakelly Zakelly requested review from masteryhx and fredia May 16, 2024 05:03
@flinkbot
Copy link
Collaborator

flinkbot commented May 16, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Overall LGTM.

*/
public ReducingStateDescriptor(
String name, ReduceFunction<T> reduceFunction, TypeInformation<T> typeInfo) {
super(name, typeInfo, null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
super(name, typeInfo, null);
super(name, typeInfo);

Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
LGTM.

@Zakelly Zakelly merged commit cc21eec into apache:master May 17, 2024
@Zakelly Zakelly deleted the f35356 branch May 17, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants