New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][3.3] Triple rest jaxrs ParamConverter support #14148
base: 3.3
Are you sure you want to change the base?
Conversation
@oxsean PTAL |
Quality Gate passedIssues Measures |
@fanlobu Is it ready for review? |
I think it is ok, I did some simple tests in local |
import java.util.Map; | ||
|
||
@SuppressWarnings({"rawtypes"}) | ||
public class JaxrsParamConverter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to rename to ParamConverterFactory, only one method getParamConverter is enough, and use the native java ServiceLoader instead of the reflection call dubbo ExtensionLoader to bypass the limitations
ParamConverter should be instantiated by using the ParamConverterProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need unit test for this.
@SuppressWarnings({"rawtypes"}) | ||
public class JaxrsParamConverter { | ||
|
||
private final Map<Pair<Class<?>, Class<?>>, ParamConverter> cacheConverter = CollectionUtils.newConcurrentHashMap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to cache
What is the purpose of the change
Triple rest jaxrs ParamConverter support,related: #14037
Brief changelog
Verifying this change
Checklist