Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move Mesh Rule Router to SPI Extensions #14069

Open
wants to merge 3 commits into
base: 3.3
Choose a base branch
from

Conversation

heliang666s
Copy link
Contributor

What is the purpose of the change

[Feature] Move Mesh Rule Router to SPI Extensions

Brief changelog

  • copy all the related classes to org.apache.dubbo.rpc.cluster.configurator.parser.model

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@wcy666103
Copy link
Contributor

wcy666103 commented Apr 11, 2024

This error is due to the version definition problem of dubbo-samples project with Dubbo-samples-meshrule-router Supported component versions of the test case, It can be asked if it is necessary to additionally exclude 3.3 @songxiaosheng
image

Like the dubbo-samples-consu module, the tests were skipped because of version

@heliang666s
Copy link
Contributor Author

Yes,I clone dubbo-samples code,I find the same problem.@wcy666103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants