Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra comparation of release_state in ProcessDefinitionMapper #16023

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Mahongsheng
Copy link

Purpose of the pull request

This pull request fix /v2/workflows/query api.

In this api, there is a method called:

IPage<ProcessDefinition> filterProcessDefinition(IPage<ProcessDefinition> page,
                                                 @Param("pd") ProcessDefinition processDefinition);

In ProcessDefinition class, there is a filed: private ReleaseState releaseState.

It's an enum type, but in xml file, we compare it with String.

Brief change log

Delete the mybatis sentence that compares releaseState to an empty String.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun
Copy link
Member

ruanwenjun commented May 18, 2024

LGTM, there exist multiple place need to fix in ProcessDefinitionMapper, please modify these in this PR, and we need to add UT for this case.

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label May 18, 2024
@ruanwenjun ruanwenjun changed the title fix: Enum cannot be compared to String Remove extra comparation with release_state in ProcessDefinitionMapper May 18, 2024
@ruanwenjun ruanwenjun changed the title Remove extra comparation with release_state in ProcessDefinitionMapper Remove extra comparation of release_state in ProcessDefinitionMapper May 18, 2024
@Mahongsheng Mahongsheng reopened this May 20, 2024
@Mahongsheng
Copy link
Author

I am trying to check this mapper and write unit tests. Please wait a minute.

@Mahongsheng
Copy link
Author

I don't find any more bugs in ProcessDefinitionMapper. And I think I have completed the unit testings for this file. Please check. Salute.

@ruanwenjun
Copy link
Member

Please fix the code style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants