Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent generation of empty revision files by alembic autogenerate #39634

Conversation

ephraimbuddy
Copy link
Contributor

When the alembic autogenerate command is run, we should prevent it from generating an empty migration file with no upgrade operation. We print on the command line that no changes were detected.

When the alembic autogenerate command is run, we should prevent it
from generating an mpty migration file with no upgrade operation.
We print on the command line that no changes were detected.
@ephraimbuddy ephraimbuddy force-pushed the prevent-generation-of-empty-migration-files branch from 1067ac5 to aa0fe29 Compare May 15, 2024 11:46
@ephraimbuddy ephraimbuddy requested a review from potiuk as a code owner May 15, 2024 11:46
@ephraimbuddy ephraimbuddy merged commit a7960a1 into apache:main May 15, 2024
40 checks passed
@ephraimbuddy ephraimbuddy deleted the prevent-generation-of-empty-migration-files branch May 15, 2024 15:07
RNHTTR pushed a commit to RNHTTR/airflow that referenced this pull request Jun 1, 2024
…pache#39634)

* Prevent generation of empty revision files by alembic autogenerate

When the alembic autogenerate command is run, we should prevent it
from generating an mpty migration file with no upgrade operation.
We print on the command line that no changes were detected.

* fixup! Prevent generation of empty revision files by alembic autogenerate
@utkarsharma2 utkarsharma2 added type:misc/internal Changelog: Misc changes that should appear in change log changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants