openlineage: remove openlineage.common dependencies in Google and Snowflake providers.
#39614
+1,125
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
JDarDagran
force-pushed
the
openlineage/remove-common-package-usage
branch
2 times, most recently
from
464aec3
to
c0b5ae7
Compare
8 tasks
JDarDagran
force-pushed
the
openlineage/remove-common-package-usage
branch
2 times, most recently
from
9f27a05
to
50b3cd9
Compare
kacpermuda
reviewed
May 14, 2024
JDarDagran
force-pushed
the
openlineage/remove-common-package-usage
branch
3 times, most recently
from
659d4bf
to
8e8aca0
Compare
|
@JDarDagran can we go with this but without removing old facets? We can notify they are deprecated and will be removed in future release. However we need better strategy to do that, and let's not block this PR on that problem. |
JDarDagran
force-pushed
the
openlineage/remove-common-package-usage
branch
from
8e8aca0
to
d86cc04
Compare
JDarDagran
force-pushed
the
openlineage/remove-common-package-usage
branch
4 times, most recently
from
da03d86
to
543aa8c
Compare
mobuchowski
requested changes
May 19, 2024
…iders. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
openlineage/remove-common-package-usage
branch
from
543aa8c
to
3cd280c
Compare
mobuchowski
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes usage of
openlineage.commondependencies in Google (BigQuery) and Snowflake providers. In both cases it externally contains logic that should be moved directly into providers.The only dependency from
openlineage.commonshould be related to OpenLineage SQLParser libraries.