-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mysql/postgres from extras before determining the installation_command_flags #39610
Remove mysql/postgres from extras before determining the installation_command_flags #39610
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Nice! Thanks! |
SOme static check failure. The other issue with tests is being fixed (broken main) |
a108664
to
e9aeae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your first PR.
Are these indentation changes intentional? Can you look into the failing checks?
e9aeae2
to
14058df
Compare
Still some static-checks failing (I recommend installing and running |
14058df
to
da477eb
Compare
@potiuk All good now. 🚀 |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
INSTALL_MYSQL_CLIENT=false
orINSTALL_POSTGRES_CLIENT=false
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.