-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implementing ansys/actions/changelogs
and adding release note in documentation
#3019
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3019 +/- ##
==========================================
- Coverage 86.63% 84.17% -2.47%
==========================================
Files 52 52
Lines 9550 9550
==========================================
- Hits 8274 8039 -235
- Misses 1276 1511 +235 |
21dd02a
to
67926bb
Compare
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Is this still a draft? @clatapie |
The changelog can be effective but I wanted to add some documentation about commit and branch name conventions. I also have planned to add the |
I will resume it next week |
As the Contributing section in the PyAnsys dev guide details the naming conventions, adding the action should be enough to ensure a consistent changelog section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add the documentation the new branch and commit names. Also mentioned the update changelog feature. Especially, if the developer needs to take something into account. Like write a meaningful PR name or similar.
Otherwise LGTM. Thank you for this @clatapie
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Implementing release note in documentation, using
ansys/actions/changelogs
and ansys/pyansys-geometry#1138.