Finish issue #128 #200
Open
Finish issue #128 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm thinking about doing some work on this library, but before I start I'm wondering will my pull request get approved? (assuming it is up to quality standards etc) or is this project orphaned now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
This is a Pull Request to fix issue #128. Someone requested that you could change the alignments of the title text, description text as well as the image.
This PR solves that problem.
I tested on Xcode's 12.4 simulators of iPhone 8 and iPhone 12
Description
To change the alignment of title when instantiating a page FeedbackPageBLTNItem() set the page's .titleAlignment to be whatever you want (.left, .right, ect). If a user does not specify then the default alignment is center.
Similarly, to change the alignment of description use the .descriptionAlignment to set to desirable alignment
And also to change the alignment of image use the .imageContentMode to set to desirable alignment