Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POLCA.sh fix for samtools current version #326

Open
hyphaltip opened this issue Aug 10, 2023 · 1 comment
Open

POLCA.sh fix for samtools current version #326

hyphaltip opened this issue Aug 10, 2023 · 1 comment

Comments

@hyphaltip
Copy link

I noticed issues with the way polca is calling samtools which breaks with current versions of samtools. When masurca is installed in an env with other samtools dependencies it is not possible to install the old version of samtools.

I modified the script slightly to work for the latest version - wonder if this can be applied to future releases to ensure compatibility?
The fixed version is available in stajichlab/AAFTF#25 as https://github.com/stajichlab/AAFTF/blob/main/patches/polca.sh and as this patch https://github.com/stajichlab/AAFTF/blob/main/patches/polca.patch

This might also be impacting #317 and #303

@Ifigene
Copy link

Ifigene commented Dec 19, 2023

Thank you so much!
I have had the same error as #317 and can confirm that this patch fixed the issue for masurca/4.1.0.

It would be nice if the developers address this in the next version of masurca! Let's see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants