Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document and show named circuitbreaker as the main option #32417

Merged
merged 4 commits into from
May 22, 2024

Conversation

johanandren
Copy link
Member

We recently noticed there are no docs of the named circuit breakers. This showcases them as the goto option with a low-level extra example of manually creating.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new samples look good

@johanandren johanandren marked this pull request as ready for review May 15, 2024 14:20
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some language nitpicking.
LGTM.

akka-docs/src/main/paradox/common/circuitbreaker.md Outdated Show resolved Hide resolved
akka-docs/src/main/paradox/common/circuitbreaker.md Outdated Show resolved Hide resolved
akka-docs/src/main/paradox/common/circuitbreaker.md Outdated Show resolved Hide resolved
akka-docs/src/main/paradox/common/circuitbreaker.md Outdated Show resolved Hide resolved
akka-docs/src/main/paradox/common/circuitbreaker.md Outdated Show resolved Hide resolved
akka-docs/src/main/paradox/common/circuitbreaker.md Outdated Show resolved Hide resolved
akka-docs/src/main/paradox/common/circuitbreaker.md Outdated Show resolved Hide resolved
Co-authored-by: Enno Runne <458526+ennru@users.noreply.github.com>
@johanandren johanandren merged commit 69cf92f into main May 22, 2024
5 checks passed
@johanandren johanandren deleted the wip-document-named-circuitbreaker branch May 22, 2024 10:04
@johanandren johanandren added this to the 2.9.4 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants