Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/grpc transcoding #1834

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Feat/grpc transcoding #1834

wants to merge 54 commits into from

Conversation

GreyPlane
Copy link

inherit the work from #1583 since it's likely abandoned

@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@GreyPlane GreyPlane mentioned this pull request Sep 27, 2023
Closed
@GreyPlane
Copy link
Author

weird blocking issue scalapb/ScalaPB#1583

@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

2 similar comments
@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@GreyPlane
Copy link
Author

I think this is ready to go, the implementation itself is stable enough to review, while I'm still working on adding more tests and documentations.

@GreyPlane GreyPlane marked this pull request as ready for review October 1, 2023 06:54
@johanandren
Copy link
Member

Nice to see work here but just so you know: we don't quite have the bandwidth to properly keep up with reviewing this PR right now, so don't think of it as something that will get merged soon.

@GreyPlane
Copy link
Author

Nice to see work here but just so you know: we don't quite have the bandwidth to properly keep up with reviewing this PR right now, so don't think of it as something that will get merged soon.

That's understandable, just knowing you guys are interested on this is enough.

@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

GreyPlane and others added 26 commits February 19, 2024 14:20
@GreyPlane
cleanup code
b7e76cc
@GreyPlane
improve comment
32a2971
@GreyPlane
use AkkaHttpClientUtils to handle gRPC response error correctly
f566dd3
@GreyPlane
improve error mapping
3d7ec28
@GreyPlane
refactoring code
19d2a01
@GreyPlane
retrieve trailer from attributes for Strict HttpEntity
8600697
@GreyPlane
add basic API test
1f4a52d
@GreyPlane
replace scala parser combinator with parboiled2
89f10d1
@GreyPlane
rename test
c5322c0
@GreyPlane
replace costly regular expression with akka-http PathMatcher
829fbd2
@GreyPlane
add matcher test case for matching complex variable pattern
7b4494f
@GreyPlane
support path like selector for path variable
369ac39
@GreyPlane
add headers
2a38a7d
@GreyPlane
fix typo
43c105f
@GreyPlane
refactor complexSelectorBuilder
c29b0c0
@GreyPlane
add more gRPC status to HTTP status mapping
f90c232
@GreyPlane
fix 2.13 build issues
8f69a14
@GreyPlane
fix 3 build issues
d281040
@GreyPlane
fix 2.13 build issues
79d6df0
@GreyPlane
fix gradle building issues for plugin-tester-java
e6a64d0
@GreyPlane
fix maven building issues for plugin-tester-scala
2b083d7
@patriknw @GreyPlane
bump: grpc 1.58.0 (akka#1856)
6617462 
* guava dependency to 32.0.1 to address CVE-2023-2976
* protobuf-java 3.24.0, which is what grpc-protobuf:1.58.0 brings in
* plugin-tester-java wasn't setting protoc version when inside sbt
* workaround for ScalaPB EnumType issue, because of ScalaPB issue 1557
* not sure, but parallelExecution false
* tests with invalid endpoints not working
* Don't use assert
* bump: sbt-paradox-dependencies 0.2.4
  * cycle between grpc-core and grpc-util
@patriknw @GreyPlane
bump: Akka 2.9.0 (akka#1863)
783255d 
* and Akka HTTP 10.6.0
@johanandren @GreyPlane
docs: gradle config that works from quickstarts (akka#1867)
59b632e 
* docs: gradle config that works from quickstarts
* Simplify plugin tester gradle setup
@GreyPlane
bump accidentally changed dependency version
1d1d772
@GreyPlane
fix: gradle plugin was missing scalaPB generated files from library p…
63bf370 
…rotos
@GreyPlane
Copy link
Author

  • Gradle plugin wouldn't generate ScalaPB classes for library protos, which causes generated Scala proto classes(user side) failed to use HTTP transcoding related proto classes, I've added these into protoSrc, but not very confident it's the right thing to do.
  • Scripted test reported huge duplicated generated proto classes, mainly from google.api.*, which I haven't figure out how to deal with.

I think these two are the remaining blocker, but it's hard to solve due I'm lacking relative experience, so any help or suggestion was appreciate.

@johanandren johanandren mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codegen gradle update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GreyPlane @lightbend-cla-validator @johanandren @WayneWang12 @patriknw