Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CallCredentials in akka-http backend #1646

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dwhjames
Copy link
Contributor

@dwhjames dwhjames commented Aug 3, 2022

Merge metadata generated by CallCredentials callback into headers at request time.


I’m putting up this PR as WiP to get feedback from maintainers.

Merge metadata generated by CallCredentials callback into headers at
request time.
@dwhjames
Copy link
Contributor Author

@raboof,

The Netty-based client has limited support for CallOptions, but it does currently support the call credentials feature.

private val options = NettyClientUtils.callOptions(settings)

/**
* INTERNAL API
*/
@InternalApi def callOptions(settings: GrpcClientSettings): CallOptions =
settings.callCredentials.map(CallOptions.DEFAULT.withCallCredentials).getOrElse(CallOptions.DEFAULT)

I was hoping to do the same for the akka-http based client.

When you have a chance, I would welcome any feedback on extending AkkaHttpClientUtils.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant