324 mac check spdz #343
Merged
324 mac check spdz #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
============================================
- Coverage 100% 99.97% -0.03%
+ Complexity 3316 3292 -24
============================================
Files 369 366 -3
Lines 9181 9108 -73
Branches 689 680 -9
============================================
- Hits 9181 9106 -75
- Misses 0 1 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
rubensayshi
reviewed
Jun 13, 2019
core/src/main/java/dk/alexandra/fresco/lib/generic/BroadcastComputation.java
Outdated
Show resolved
Hide resolved
core/src/main/java/dk/alexandra/fresco/lib/generic/CommitmentComputation.java
Show resolved
Hide resolved
core/src/test/java/dk/alexandra/fresco/lib/generic/MaliciousCommitmentComputation.java
Show resolved
Hide resolved
core/src/main/java/dk/alexandra/fresco/lib/generic/CommitmentComputation.java
Outdated
Show resolved
Hide resolved
|
@rubensayshi awesome, thanks for the review! All good points. Addressed in 5f9eb04. |
jot2re
requested changes
Jun 16, 2019
...e/spdz2k/src/main/java/dk/alexandra/fresco/suite/spdz2k/resource/Spdz2kResourcePoolImpl.java
Show resolved
Hide resolved
suite/spdz/src/main/java/dk/alexandra/fresco/suite/spdz/gates/SpdzMacCheckProtocol.java
Outdated
Show resolved
Hide resolved
.../java/dk/alexandra/fresco/suite/spdz2k/protocols/computations/Spdz2kMacCheckComputation.java
Show resolved
Hide resolved
pffrandsen
approved these changes
Jun 18, 2019
|
|
||
| BroadcastComputation(List<byte[]> input) { | ||
| public BroadcastComputation(List<byte[]> input, boolean runValidation) { |
There was a problem hiding this comment.
I think it is reasonable to document this class and the constructor - especially when it it resonable to use one or the other
| final AesCtrDrbg localDrbg = new AesCtrDrbg(); | ||
| final HashBasedCommitmentSerializer commitmentSerializer = new HashBasedCommitmentSerializer(); | ||
|
|
||
| return builder.seq(new CoinTossingComputation(drbgSeedBitLength / 8, |
There was a problem hiding this comment.
Please reconsider the alignment here
There was a problem hiding this comment.
Actually check the entire file :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #324 which is a bug in our SPDZ mac-checking protocol.
In particular, we need to run a fresh coin tossing each time we run a MAC check. To implement this, the PR moves several generic computations (for instance
BroadcastComputation) out of SPDZ2k and into core, so these can be re-used across protocol suites.Re-using these generic computations also allows us to remove some classes that were previously SPDZ-specific (e.g.,
SpdzCommitProtocol) and use the same commitment functionality as is currently used in MASCOT.