-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix the performance issue of DeepACO #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work! I have added some comments.
Made some modifications following the discussions above. |
I guess so, we had a look at that too. Right @hyeok9855 ? |
@Furffico did the above fixes make DeepACO match the performance in your paper? |
Yes. With a parallelized AS and a better pheromone update function, it's faster and sometimes perform better than our original implementation. |
Good! Will the same hold with local search too @hyeok9855 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will check the code more thoroughly later when I work for the local search #140 (maybe next week).
Thanks for your work!
Yes, very likely. |
I think there's no further modifications required in this PR. Shall we merge it now? |
Description
This pull request fixes the performance issue of the DeepACO implementation, and makes some tiny modifications to enhance the performance.