Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix the performance issue of DeepACO #170

Merged
merged 3 commits into from
May 25, 2024

Conversation

Furffico
Copy link
Contributor

@Furffico Furffico commented May 6, 2024

Description

This pull request fixes the performance issue of the DeepACO implementation, and makes some tiny modifications to enhance the performance.

@fedebotu fedebotu requested a review from hyeok9855 May 6, 2024 17:16
Copy link
Contributor

@hyeok9855 hyeok9855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! I have added some comments.

rl4co/models/zoo/deepaco/antsystem.py Outdated Show resolved Hide resolved
rl4co/models/zoo/deepaco/antsystem.py Outdated Show resolved Hide resolved
rl4co/models/zoo/deepaco/antsystem.py Show resolved Hide resolved
rl4co/models/zoo/nargnn/encoder.py Outdated Show resolved Hide resolved
@Furffico
Copy link
Contributor Author

Made some modifications following the discussions above.
BTW, rl4co/models/zoo/deepaco/decoder.py seems redundant. Is it ok to delete this file?

@fedebotu
Copy link
Member

I guess so, we had a look at that too. Right @hyeok9855 ?

@Furffico Furffico requested a review from hyeok9855 May 15, 2024 04:35
@fedebotu
Copy link
Member

@Furffico did the above fixes make DeepACO match the performance in your paper?

@Furffico
Copy link
Contributor Author

@Furffico did the above fixes make DeepACO match the performance in your paper?

Yes. With a parallelized AS and a better pheromone update function, it's faster and sometimes perform better than our original implementation.

@fedebotu
Copy link
Member

Yes. With a parallelized AS and a better pheromone update function, it's faster and sometimes perform better than our original implementation.

Good! Will the same hold with local search too @hyeok9855 ?

Copy link
Contributor

@hyeok9855 hyeok9855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I will check the code more thoroughly later when I work for the local search #140 (maybe next week).
Thanks for your work!

@hyeok9855
Copy link
Contributor

Good! Will the same hold with local search too @hyeok9855 ?

Yes, very likely.

@Furffico
Copy link
Contributor Author

I think there's no further modifications required in this PR. Shall we merge it now?

@fedebotu fedebotu merged commit 1252b8c into ai4co:main May 25, 2024
12 checks passed
@Furffico Furffico deleted the deepaco-bugfix branch May 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants