Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ppo.py #167

Closed
wants to merge 1 commit into from
Closed

Update ppo.py #167

wants to merge 1 commit into from

Conversation

bokveizen
Copy link
Member

added "load_from_checkpoint" for PPO

Description

The method "load_from_checkpoint" was missing in PPO.

Motivation and Context

It allows "load_from_checkpoint" of PPOModel for instances now.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

added "load_from_checkpoint" for PPO
@fedebotu
Copy link
Member

Thanks! The previous version was not working?
Asking because the load_from_checkpoint is actually overwriting a class method of the LightningModule as seen here, so if it does not cause problems, it could be left

@bokveizen bokveizen closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants