Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing bibcode desc sorts #75

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

removing bibcode desc sorts #75

wants to merge 4 commits into from

Conversation

femalves
Copy link

No description provided.

@femalves femalves requested a review from tjacovich April 15, 2024 15:28
tjacovich
tjacovich reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@tjacovich tjacovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think the next step is going to be writing an alembic upgrade that can update the stored queries in vault as well, just need to verify whether the sorts are saved in the queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjacovich tjacovich tjacovich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@femalves @tjacovich