Update path aliases and move logger #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
========================================
- Coverage 47.3% 47.3% -0.0%
========================================
Files 425 425
Lines 44389 44446 +57
Branches 597 598 +1
========================================
+ Hits 20988 21006 +18
- Misses 23390 23429 +39
Partials 11 11
|
shinyichen
reviewed
Apr 30, 2024
src/middlewares/initSession.ts
Outdated
| @@ -141,10 +141,11 @@ export const initSession = async (req: NextRequest, res: NextResponse) => { | |||
| if (isValidToken(token)) { | |||
| session.token = token; | |||
| session.isAuthenticated = isAuthenticated(token); | |||
| res.cookies.set(process.env.ADS_SESSION_COOKIE_NAME, headers.get('set-cookie') ?? ''); | |||
| log.debug({ msg: 'headers', headers: headers.entries() }); | |||
| const sessionCookieValue = headers.get('set-cookie').split('=')[1] ?? ''; | |||
There was a problem hiding this comment.
possible undefined value on headers.get('set-cookie')?
shinyichen
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the root path alias from
@to@/which shows more explicitly project files vs external libs that might use that same syntax