Implement the 10k Test Suite #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed to patch an issue in PyUnicode so I made a new fork; will remove if/when it gets upstreamed.
Prior to this the code would error out because it expected at least 1 part. In cases where there are additional parenthesis around the string (it happens), and other miscellaneous inputs, there can be 0 parts instead.
This causes the unparsed author name to pass through the system. In previous versions there would be (incorrect) null characters added to the output of this pass if the author name couldn't be parsed.
This normalization pass helps to consolidate the Unicode code points in the string prior to other passes. Without this step some important parts of certain code points can be eliminated, resulting in mangled output.
|
Added @ehenneken and @aaccomazzi to double check the unicode normalization fixes. cc @kelockhart |
shinyichen
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10k Test Suite - Catching query parsing regressions in development
What?
This PR implements a test suite of ~13k roughly deduplicated user queries to prevent parser regressions. It also includes some bug fixes that were necessary to get this test case working, including a particularly pernicious unicode normalization bug.
Why?
As we change Montysolr's query engine, it's important that users' queries continue to work as expected. This PR ensures there's no gap in functionality between versions.
Completion tracking
What next?