Implement negative position search #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCRPaquin
commented
Mar 7, 2024
...main/java/org/apache/lucene/queryparser/flexible/aqp/builders/AqpAdsabsSubQueryProvider.java
Show resolved
Hide resolved
JCRPaquin
commented
Mar 7, 2024
montysolr/src/main/java/org/apache/lucene/search/spans/SpanNegativeIndexRangeQuery.java
Show resolved
Hide resolved
JCRPaquin
commented
Mar 7, 2024
montysolr/src/main/java/org/apache/lucene/search/spans/SpanPositionAndDocumentQuery.java
Show resolved
Hide resolved
shinyichen
approved these changes
Mar 12, 2024
kelockhart
reviewed
Mar 12, 2024
montysolr/src/main/java/org/apache/lucene/search/spans/SpanNegativeIndexRangeQuery.java
Show resolved
Hide resolved
montysolr/src/main/java/org/apache/lucene/search/spans/SpanNegativeIndexRangeQuery.java
Show resolved
Hide resolved
montysolr/src/main/java/org/apache/lucene/search/spans/SpanNegativeIndexRangeQuery.java
Outdated
Show resolved
Hide resolved
montysolr/src/main/java/org/apache/lucene/search/spans/SpanNegativeIndexRangeQuery.java
Show resolved
Hide resolved
montysolr/src/main/java/org/apache/lucene/search/spans/SpanNegativeIndexRangeQuery.java
Show resolved
Hide resolved
...main/java/org/apache/lucene/queryparser/flexible/aqp/builders/AqpAdsabsSubQueryProvider.java
Show resolved
Hide resolved
montysolr/src/test/java/org/apache/lucene/search/TestNegativePositionQueries.java
Show resolved
Hide resolved
This enables us to drop quotes around numbers in the `pos` operator.
Also breaks all the testcases out into named tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Some academic fields rely on last author information, similar to how other fields rely on first author information. ADS currently does not support last author search.
Purpose
This PR adds support for negative index queries, with a minor syntax caveat that all negative indices must be in quotation marks. Future work will modify the ADS grammar to allow negative indices without quotation marks, and possibly syntax sugar to make exact last author searches more streamlined.
Additional changes
How query fields are determined has been extended to support a broader gamut of query types. This change was necessary to get accurate field information from the sub-queries passed into the negative range query.