GA4 Updates #2283
Merged
GA4 Updates #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thostetler
commented
Feb 5, 2024
thostetler
commented
- add proper GTM tag
- fix up analytics calls where necessary
thostetler
force-pushed
the
GA4-updates
branch
from
6357d6f
to
e1b3815
Compare
Removing the analytics test for now. This test was mainly used to make sure the array was properly pushed to, and that it does the right thing if the global is undefined. I think this module is simple enough to leave as a proxy to the GTM call. We can add more testing for the logger in the future.
shinyichen
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.