New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug #6
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to start. I'm not sure we should merge it in currently, but we can build from this branch and test it out in dev next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Fingers crossed it gives us something to chase down.
if isinstance(item, Article): | ||
current_app.logger.info(f"Item is an article: {item.id}") | ||
object_name = f'{item.id}.pdf' | ||
full_path = f'pdfs/{object_name}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hitting full path with 'object_name'.lower()
might resolve the 404 issues. You'll just want to make sure that other places that use full path don't care if the case changes.
No description provided.