Xref affil.20240312 #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: adsingestp/parsers/crossref.py
modified: adsingestp/parsers/crossref.py modified: tests/stubdata/output/crossref_cn_10.1093=mnras=stac2975.json modified: tests/stubdata/output/crossref_cn_10.1093=pasj=psac053.json
modified: adsingestp/parsers/crossref.py
ehenneken
reviewed
Mar 13, 2024
There was a problem hiding this comment.
In this example, affiliations are specified by ROR, rather than an explicit string. Is there an easy way to capture and convert these?
|
Will create a new PR from a more up-to-date branch, addressing the ROR suggestion. |
|
The capture of identifiers is a larger issue than Crossref and will be dealt with separately in Issue #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds additional handling for crossref data for the case where records have affiliation data embedded in the
<affiliations>tag, rather than<affiliation>