-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added handling for simple-article #93
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 89.99% 90.29% +0.30%
==========================================
Files 25 25
Lines 2618 2627 +9
==========================================
+ Hits 2356 2372 +16
+ Misses 262 255 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I have one suggestion: in def parse(), would you please raise an exception immediately after the check for d.find("ja:simple-article") (L370) if the result is still self.record_meta=None
? If self.record_meta
is nonetype, the remainder of the code is going to generate an exception at some point, so I think it makes sense to stop execution there before it starts executing the self._parse_*
statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the "elif" in L370 to if -- this will guarantee the line is executed regardless of what happens in L368.
I am considering revising slightly how we do this in light of the number of document types that Elsevier may provide in addition to
We don't necessarily want all of these, but certainly a subset of them. |
P.S. : Also added some clean up statements for titles.