Improves affiliation capture from Crossref #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: adsingestp/parsers/crossref.py modified: tests/stubdata/output/crossref_cn_10.1093=mnras=stac2975.json modified: tests/stubdata/output/crossref_cn_10.1093=pasj=psac053.json
mugdhapolimera
requested changes
May 6, 2024
| @@ -265,6 +265,30 @@ def _parse_contrib(self): | |||
| affil = [a.get_text() for a in c.find_all("affiliation")] | |||
| if affil: | |||
| contrib_tmp["aff"] = affil | |||
| elif c.find("affiliations"): | |||
There was a problem hiding this comment.
Is there ever a situation where there is more than one affiliations tag for a single author? Try to check if there is a use case for find_all rather than find here.
There was a problem hiding this comment.
Not every publisher uses the structure; Elsevier is an example of one that does not. OUP and MDPI both do, and none of their crossref records contain more than one <affiliations> tag per author, so using find should be sufficient
mugdhapolimera
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #96 . The broader issue of capturing ROR and other affiliation identifier data is raised in Issue #104 and will be the subject of a separate PR.