Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed subscript, superscript, italics, bold tags for elsevier #101

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

mugdhapolimera
Copy link
Contributor

#99

@mugdhapolimera
Copy link
Contributor Author

@seasidesparrow please note that the changes to base.py did modify the parsing for other parsers like jats. I haven't updated all of them yet, because I'd like your feedback to see if this is working well. Once we settle on a solution, I can modify other files.

Copy link
Member

@seasidesparrow seasidesparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change: the tests in test_jats have print(test_infile) statements that should be removed. Otherwise it looks good.

@seasidesparrow
Copy link
Member

The json output for els_missing_keywords_tag.xml is missing the abstract. The abstract is present in the xml file as the following

<ce:abstract id="abs0010" view="all" class="author"><ce:abstract-sec id="abssec0010" view="all"><ce:simple-para id="abspara0010" view="all">In this issue of <ce:italic>Chem</ce:italic>, Nagib and co-workers report an operationally simple approach for direct C&#x2013;H halogenation of arenes and (hetero)arenes through <ce:italic>in&#160;situ</ce:italic> activation of commercially available PhI(OAc)<ce:inf loc="post">2</ce:inf>. The resulting non-symmetrical iodanes offer chemists new tools for the mild halogenation of arene scaffolds with exquisite selectivity and tunability.</ce:simple-para></ce:abstract-sec></ce:abstract><ce:abstract class="teaser" id="abs0015" view="all"><ce:abstract-sec id="abssec0015" view="all"><ce:simple-para id="abspara0015" view="all">In this issue of <ce:italic>Chem</ce:italic>, Nagib and co-workers report an operationally simple approach for direct C&#x2013;H halogenation of arenes and (hetero)arenes through <ce:italic>in situ</ce:italic> activation of commercially available PhI(OAc)<ce:inf loc="post">2</ce:inf>. The resulting non-symmetrical iodanes offer chemists new tools for the mild halogenation of arene scaffolds with exquisite selectivity and tunability.</ce:simple-para></ce:abstract-sec></ce:abstract>

What we have in the tagged (online) data is:

In this issue of Chem, Nagib and co-workers report an operationally simple approach for direct C-H halogenation of arenes and (hetero)arenes through in situ activation of commercially available PhI(OAc)2. The resulting non-symmetrical iodanes offer chemists new tools for the mild halogenation of arene scaffolds with exquisite selectivity and tunability.

Copy link
Member

@seasidesparrow seasidesparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please merge & release at your earliest convenience.

@mugdhapolimera mugdhapolimera merged commit b8888cc into adsabs:main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elsevier: Translate markup in input files to standard markup for super/sub scripts
2 participants