-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed subscript, superscript, italics, bold tags for elsevier #101
Conversation
@seasidesparrow please note that the changes to base.py did modify the parsing for other parsers like jats. I haven't updated all of them yet, because I'd like your feedback to see if this is working well. Once we settle on a solution, I can modify other files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change: the tests in test_jats have print(test_infile)
statements that should be removed. Otherwise it looks good.
The json output for els_missing_keywords_tag.xml is missing the abstract. The abstract is present in the xml file as the following
What we have in the tagged (online) data is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please merge & release at your earliest convenience.
#99