Merge pull request #86 from seasidesparrow/eissn_copernicus.20240213

fix: copernicus electronic issn captured correctly
adsabs · Feb 14, 2024 · ad90d2f · ad90d2f
2 parents 0938a1c + 74b2ef0
commit ad90d2f
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/adsingestp/parsers/copernicus.py b/adsingestp/parsers/copernicus.py
@@ -58,7 +58,7 @@ def _parse_ids(self):
             issns.append(("print", self.input_metadata.find("issn").get_text()))
 
         if self.input_metadata.find("eissn"):
-            issns.append(("electronic", self.input_metadata.find("issn").get_text()))
+            issns.append(("electronic", self.input_metadata.find("eissn").get_text()))
 
         self.base_metadata["issn"] = issns
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -52,9 +52,9 @@ dev = [
     'semantic-release==0.1.0',
 ]
 docs = [
-    'Sphinx==4.3.1',
-    'myst-parser==0.15.2',
-    'sphinx-rtd-theme==1.0.0'
+    'Sphinx==7.2.6',
+    'myst-parser==2.0.0',
+    'sphinx-rtd-theme==2.0.0'
 ]
 
 

diff --git a/tests/stubdata/output/copernicus_ESSD_essd-15-3075-2023.json b/tests/stubdata/output/copernicus_ESSD_essd-15-3075-2023.json
@@ -22,7 +22,7 @@
       },
       {
         "pubtype": "electronic",
-        "issnString": "1866-3508"
+        "issnString": "1866-3516"
       }
     ]
   },

diff --git a/tests/stubdata/output/copernicus_GeChr_gchron-5-323-2023.json b/tests/stubdata/output/copernicus_GeChr_gchron-5-323-2023.json
@@ -22,7 +22,7 @@
       },
       {
         "pubtype": "electronic",
-        "issnString": "2628-3697"
+        "issnString": "2628-3719"
       }
     ]
   },

diff --git a/tests/stubdata/output/copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json b/tests/stubdata/output/copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
@@ -22,7 +22,7 @@
       },
       {
         "pubtype": "electronic",
-        "issnString": "2194-9042"
+        "issnString": "2194-9050"
       }
     ]
   },

diff --git a/tests/stubdata/output/copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json b/tests/stubdata/output/copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
@@ -22,7 +22,7 @@
       },
       {
         "pubtype": "electronic",
-        "issnString": "1682-1750"
+        "issnString": "2194-9034"
       }
     ]
   },

diff --git a/tests/stubdata/output/copernicus_wes-8-1625-2023.json b/tests/stubdata/output/copernicus_wes-8-1625-2023.json
@@ -143,7 +143,7 @@
         "pubtype": "print"
       },
       {
-        "issnString": "2366-7443",
+        "issnString": "2366-7451",
         "pubtype": "electronic"
       }
     ],