second way to fix activity leak after configuration change #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpasha
changed the title
|
Thanks for the contribution |
DevSrSouza
added a commit
that referenced
this pull request
May 21, 2024
DevSrSouza
added a commit
that referenced
this pull request
May 21, 2024
* Lifecycle KMP experimental support * update api dump * Renaming files * fix namespace * Fix changes * apply fix from #418 * Fix lint
vickyleu
pushed a commit
to vickyleu/voyager
that referenced
this pull request
May 28, 2024
) (cherry picked from commit 6abfb57)
vickyleu
pushed a commit
to vickyleu/voyager
that referenced
this pull request
May 28, 2024
* Lifecycle KMP experimental support * update api dump * Renaming files * fix namespace * Fix changes * apply fix from adrielcafe#418 * Fix lint (cherry picked from commit 309e6c7)
vickyleu
added a commit
to vickyleu/voyager
that referenced
this pull request
May 28, 2024
* Lifecycle KMP experimental support * update api dump * Renaming files * fix namespace * Fix changes * apply fix from adrielcafe#418 * Fix lint (cherry picked from commit 309e6c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation to this PR
#415
I think this solution is better and i also checked it in our project
I don't actually see where
onDisposeinAndroidScreenLifecycleOwnerwould be called when configuration changes. And I think it's the client ofAndroidScreenLifecycleOwnerresponsibility to decide when to dispose it@DevSrSouza what to you think?