Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert netlify back to v15 #4446

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: revert netlify back to v15 #4446

merged 1 commit into from
May 13, 2024

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented May 13, 2024

Description

Updating netlify to v17.0.0 caused issues in publishing the VRTs site.

Reference

Motivation and context

How has this been tested?

  • Test case 1
    1. Go here
    2. Do this
  • Test case 2
    1. Go here
    2. Do this

Screenshots (if appropriate)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@Rajdeepc Rajdeepc changed the title chore: test commit [DO NOT MERGE]: chore: test commit May 13, 2024
Copy link

github-actions bot commented May 13, 2024

Branch preview

Copy link

github-actions bot commented May 13, 2024

Tachometer results

Currently, no packages are changed by this PR...

Copy link

github-actions bot commented May 13, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 224.801 kB 210.317 kB 🏆 210.502 kB
Scripts 54.136 kB 48.186 kB 🏆 48.214 kB
Stylesheet 34.937 kB 30.34 kB 🏆 30.467 kB
Document 5.918 kB 5.186 kB 🏆 5.188 kB
Font 126.85 kB 126.605 kB 🏆 126.633 kB

Request Count

Category Latest Main Branch
Total 48 45 45
Scripts 37 37 37
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@TarunAdobe TarunAdobe changed the title [DO NOT MERGE]: chore: test commit revert netlify back to v15 May 13, 2024
@TarunAdobe TarunAdobe self-requested a review May 13, 2024 14:19
@Rajdeepc Rajdeepc changed the title revert netlify back to v15 fix: revert netlify back to v15 May 13, 2024
Copy link
Contributor

@TarunAdobe TarunAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@TarunAdobe TarunAdobe merged commit 7835eb8 into main May 13, 2024
50 checks passed
@TarunAdobe TarunAdobe deleted the test-netlify branch May 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants