chore(picker): added a new interaction strategy #4396

TarunAdobe · 2024-05-03T10:05:11Z

Description

Expected behavior
pointerup in mobile should not automatically make a selection.

Actual behavior
pointerup in mobile works like in desktop and automatically makes a selection.

Related issue(s)

[Bug]: Picker in mobile that opens under the options that will be displayed will automatically close (make a selection) #4227
[Bug]: (iOS) sp-card (supplied with an actions slot) action menu opens tray and on menu item selection in tray, if other card is behind it registers click on it as well. #4461

Motivation and context

How has this been tested?

Test case 1
1. Go here
2. Do this
Test case 2
1. Go here
2. Do this

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

github-actions · 2024-05-03T10:07:27Z

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions · 2024-05-03T10:26:43Z

Tachometer results

Chrome

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	647 kB	131.27ms - 134.19ms	-	faster ✔ 8% - 10% 11.47ms - 15.37ms
branch	638 kB	144.86ms - 147.45ms	slower ❌ 9% - 12% 11.47ms - 15.37ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	604 kB	60.51ms - 61.63ms	-	faster ✔ 11% - 14% 7.90ms - 9.67ms
branch	595 kB	69.17ms - 70.53ms	slower ❌ 13% - 16% 7.90ms - 9.67ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	603 kB	58.98ms - 60.28ms	-	faster ✔ 12% - 14% 7.87ms - 9.70ms
branch	594 kB	67.78ms - 69.07ms	slower ❌ 13% - 16% 7.87ms - 9.70ms	-

test-open-close-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	790 kB	1872.32ms - 1875.45ms	-	unsure 🔍 -0% - -0% -6.33ms - -2.08ms
branch	740 kB	1876.65ms - 1879.52ms	unsure 🔍 +0% - +0% +2.08ms - +6.33ms	-

test-open-close permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	788 kB	1857.63ms - 1860.46ms	-	faster ✔ 1% - 1% 13.15ms - 17.25ms
branch	779 kB	1872.76ms - 1875.72ms	slower ❌ 1% - 1% 13.15ms - 17.25ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	513 kB	519.70ms - 533.13ms	-	faster ✔ 2% - 6% 12.40ms - 32.23ms
branch	504 kB	541.43ms - 556.03ms	slower ❌ 2% - 6% 12.40ms - 32.23ms	-

split-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	723 kB	1857.54ms - 1860.96ms	-	unsure 🔍 -0% - +0% -4.23ms - +1.27ms
branch	714 kB	1858.57ms - 1862.88ms	unsure 🔍 -0% - +0% -1.27ms - +4.23ms	-

Firefox

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	647 kB	274.91ms - 277.65ms	-	faster ✔ 13% - 15% 41.91ms - 47.09ms
branch	638 kB	318.58ms - 322.98ms	slower ❌ 15% - 17% 41.91ms - 47.09ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	604 kB	128.17ms - 130.87ms	-	faster ✔ 3% - 5% 4.16ms - 7.16ms
branch	595 kB	134.51ms - 135.85ms	slower ❌ 3% - 6% 4.16ms - 7.16ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	603 kB	151.93ms - 157.59ms	-	slower ❌ 5% - 11% 7.80ms - 15.28ms
branch	594 kB	140.78ms - 145.66ms	faster ✔ 5% - 10% 7.80ms - 15.28ms	-

test-open-close-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	790 kB	1914.92ms - 1925.00ms	-	slower ❌ 1% - 1% 16.23ms - 26.73ms
branch	740 kB	1897.02ms - 1899.94ms	faster ✔ 1% - 1% 16.23ms - 26.73ms	-

test-open-close permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	788 kB	1883.46ms - 1887.82ms	-	faster ✔ 0% - 1% 6.72ms - 14.56ms
branch	779 kB	1893.02ms - 1899.54ms	slower ❌ 0% - 1% 6.72ms - 14.56ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	513 kB	996.40ms - 1021.48ms	-	faster ✔ 4% - 6% 39.53ms - 65.55ms
branch	504 kB	1058.02ms - 1064.94ms	slower ❌ 4% - 7% 39.53ms - 65.55ms	-

split-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	723 kB	1874.66ms - 1879.34ms	-	unsure 🔍 -0% - +0% -1.82ms - +4.30ms
branch	714 kB	1873.79ms - 1877.73ms	unsure 🔍 -0% - +0% -4.30ms - +1.82ms	-

github-actions · 2024-05-23T07:14:38Z

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	221.222 kB	210.25 kB 🏆	210.522 kB
Scripts	53.428 kB	48.114 kB 🏆	48.254 kB
Stylesheet	34.808 kB	30.249 kB 🏆	30.389 kB
Document	5.98 kB	5.272 kB	5.191 kB 🏆
Font	127.006 kB	126.615 kB 🏆	126.688 kB

Request Count

Category	Latest	Main	Branch
Total	45	45	45
Scripts	37	37	37
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

chore: testing a click controller strategy for picker component

2c453c0

TarunAdobe added 2 commits May 9, 2024 09:02

Merge branch 'main' into bug/picker-auto-slection

ea3cfae

chore: testing a new interaction strategy for picker

6543a94

TarunAdobe force-pushed the bug/picker-auto-slection branch from a5d671b to 106aa6c Compare May 23, 2024 06:53

TarunAdobe changed the title ~~[DRAFT]: Testing an Interaction Controller Strategy for Picker Component~~ chore: Adding a Interaction Controller Strategy for Picker Component May 23, 2024

TarunAdobe changed the title ~~chore: Adding a Interaction Controller Strategy for Picker Component~~ chore: Adding an Interaction Controller Strategy for Picker Component May 23, 2024

TarunAdobe marked this pull request as ready for review May 23, 2024 06:55

TarunAdobe self-assigned this May 23, 2024

TarunAdobe added the Component: Picker label May 23, 2024

fix: separated interaction strategy for picker

757b90e

TarunAdobe force-pushed the bug/picker-auto-slection branch from 106aa6c to 757b90e Compare May 23, 2024 07:10

TarunAdobe changed the title ~~chore: Adding an Interaction Controller Strategy for Picker Component~~ chore(picker): added a new interaction strategy May 28, 2024

chore: updated the strategy to include the dependency controller

814916d

TarunAdobe requested a review from a team May 28, 2024 05:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(picker): added a new interaction strategy #4396

chore(picker): added a new interaction strategy #4396

TarunAdobe commented May 3, 2024 •

edited

github-actions bot commented May 3, 2024 •

edited

github-actions bot commented May 3, 2024 •

edited

action-menu permalink

test-basic

test-directive permalink

test-lazy permalink

test-open-close-directive permalink

test-open-close permalink

picker permalink

basic-test

split-button permalink

basic-test

action-menu permalink

test-basic

test-directive permalink

test-lazy permalink

test-open-close-directive permalink

test-open-close permalink

picker permalink

basic-test

split-button permalink

basic-test

github-actions bot commented May 23, 2024 •

edited

chore(picker): added a new interaction strategy #4396

Are you sure you want to change the base?

chore(picker): added a new interaction strategy #4396

Conversation

TarunAdobe commented May 3, 2024 • edited

Description

Related issue(s)

Motivation and context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Checklist

Best practices

github-actions bot commented May 3, 2024 • edited

Branch preview

github-actions bot commented May 3, 2024 • edited

Tachometer results

action-menu permalink

test-basic

test-directive permalink

test-lazy permalink

test-open-close-directive permalink

test-open-close permalink

picker permalink

basic-test

split-button permalink

basic-test

action-menu permalink

test-basic

test-directive permalink

test-lazy permalink

test-open-close-directive permalink

test-open-close permalink

picker permalink

basic-test

split-button permalink

basic-test

github-actions bot commented May 23, 2024 • edited

Lighthouse scores

Transfer Size

Request Count

TarunAdobe commented May 3, 2024 •

edited

github-actions bot commented May 3, 2024 •

edited

github-actions bot commented May 3, 2024 •

edited

github-actions bot commented May 23, 2024 •

edited