refactor(overlay): make interaction controllers more lazy #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
combobox permalinkbasic-test
light-dom-test permalink
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
Firefoxaction-bar permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
combobox permalinkbasic-test
light-dom-test permalink
menu permalinktest-basic
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker permalinkbasic-test
popover permalinktest-basic
split-button permalinkbasic-test
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
|
Westbrook
force-pushed
the
lazy-interaction-controller
branch
2 times, most recently
from
d9d34de
to
62ce3a9
Compare
Rajdeepc
reviewed
Apr 29, 2024
| @@ -384,7 +386,10 @@ export class AbstractOverlay extends SpectrumElement { | |||
| return overlay; | |||
| } | |||
|
|
|||
| static applyOptions(overlay: Overlay, options: OverlayOptions): void { | |||
| static applyOptions( | |||
| overlay: AbstractOverlay, | |||
There was a problem hiding this comment.
Just for curiosity which subclasses or properties we are trying to bring in by changing to AbstractOverlay from Overlay?
There was a problem hiding this comment.
An Overlay is an AbstractOverlay but AbstractOverlay comes with less transient dependencies, so there is less JS loaded when using this class in overlay-trigger-directive.ts
| this.overlay.open = open; | ||
| return; | ||
| } | ||
| if (!open) { |
There was a problem hiding this comment.
can we keep this above line 42?
There was a problem hiding this comment.
If there is a value for this.overlay we want to apply it. If there isn't a value, and the state is closed, this is the same as having no Overlay at all, so we early return. I can add some comments on this.
Westbrook
force-pushed
the
lazy-interaction-controller
branch
from
62ce3a9
to
5873eec
Compare
Westbrook
force-pushed
the
lazy-interaction-controller
branch
from
5873eec
to
f2a7dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow an interaction controller to be created without requiring the presence of an Overlay
How has this been tested?
Types of changes
Checklist