chore: update to lit@3.0 #4292
Merged
chore: update to lit@3.0 #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-dialog permalinkbasic-test
asset permalinkbasic-test
avatar permalinktest-basic
badge permalinkbasic-test
banner permalinktest-basic
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-area permalinkbasic-test
color-field permalinkbasic-test
color-handle permalinkbasic-test
color-loupe permalinkbasic-test
color-slider permalinkbasic-test
color-wheel permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
dialog permalinkbasic-test
divider permalinkbasic-test
dropzone permalinktest-basic
field-group permalinkbasic-test
field-label permalinkbasic-test
grid permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
illustrated-message permalinktest-basic
infield-button permalinkbasic-test
link permalinktest-basic
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
progress-circle permalinkbasic-test
quick-actions permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
sidenav permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
split-view permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
thumbnail permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
tray permalinkbasic-test
truncated permalinkbasic-test
underlay permalinkbasic-test
Firefoxaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-dialog permalinkbasic-test
asset permalinkbasic-test
avatar permalinktest-basic
badge permalinkbasic-test
banner permalinktest-basic
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-area permalinkbasic-test
color-field permalinkbasic-test
color-handle permalinkbasic-test
color-loupe permalinkbasic-test
color-slider permalinkbasic-test
color-wheel permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
dialog permalinkbasic-test
divider permalinkbasic-test
dropzone permalinktest-basic
field-group permalinkbasic-test
field-label permalinkbasic-test
grid permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
illustrated-message permalinktest-basic
infield-button permalinkbasic-test
link permalinktest-basic
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
progress-circle permalinkbasic-test
quick-actions permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
sidenav permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
split-view permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
thumbnail permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
tray permalinkbasic-test
truncated permalinkbasic-test
underlay permalinkbasic-test
|
Westbrook
force-pushed
the
lit3
branch
3 times, most recently
from
198d5a7
to
32c0626
Compare
Rajdeepc
reviewed
Apr 25, 2024
| changes.has('open') && | ||
| (typeof changes.get('open') !== 'undefined' || this.open) | ||
| ) { | ||
| if (changes.has('open') && (this.hasUpdated || this.open)) { |
There was a problem hiding this comment.
if we already trying to find 'open' attributes from the PropertyValues do we also need a check on this.open ?
There was a problem hiding this comment.
This specific says, when open has changed, but NOT when open has changed from undefined (its initial value) to false (its default value). That was the if only returns true when it's not the first update or the end user applied open === true in the DOM of the element before it was upgraded.
| @@ -47,6 +46,7 @@ export const runOverlayTriggerTests = (type: string): void => { | |||
| justify-content: center; | |||
| } | |||
| </style> | |||
| <input type="text" /> | |||
There was a problem hiding this comment.
Yes, the test was giving issues getting into "focus visible", and this makes it easier to enforce that by allowing the test to Tab from the input to the test element.
| external: ['@spectrum-web-components/*'], | ||
| external: [ | ||
| '@spectrum-web-components/*', | ||
| 'lit-html', |
There was a problem hiding this comment.
Curious to know why the lit packages are added here?
There was a problem hiding this comment.
Because without it we've been shipping multiple copies to our docs site:
| @@ -29,7 +29,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@open-wc/building-rollup": "^3.0.2", | |||
| "@open-wc/eslint-config": "^12.0.0", | |||
| "@open-wc/eslint-config": "^12.0.3", | |||
There was a problem hiding this comment.
is this updated required in this PR?
|
@Westbrook Do you think its a good idea to point out the pros of upgrading to |
|
What sort of benefits do you think users might be interested in? This is a dependency of our code which is allowed to live next to alternate versions of itself, so it should be generally transparent to consumers. |
Westbrook
force-pushed
the
lit3
branch
3 times, most recently
from
84c8a53
to
3f7d236
Compare
Rajdeepc
previously approved these changes
Apr 26, 2024
Westbrook
force-pushed
the
lit3
branch
6 times, most recently
from
558e939
to
132e53d
Compare
|
awesome!! thanks for this work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to
lit@3.0and actually works! This may be worth holding for 1.0, if we can actually see 1.0 coming in this quarter, but 3.0 has been the default version of Lit for a while now and there are teams being held back by not being able to start greenfield projects due to our lack of support here previously.Leverages the
^2.0 || ^3.0syntax for versions, but at some point a bandaid pull is appropriate here.Related issue(s)
How has this been tested?
Types of changes
Checklist