fix(action-bar): include focus-visible polyfilling #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a member of Adobe, Inc. you should be able to self serve access to this repo and make this PR as a branch, rather than a fork, and enjoy our full CI coverage. Would you be able to set that up and reopen this PR? |
Westbrook
reviewed
Apr 25, 2024
packages/action-bar/src/ActionBar.ts
Outdated
| export const actionBarVariants = ['sticky', 'fixed']; | ||
|
|
||
| /** | ||
| * @element sp-action-bar | ||
| * @slot - Content to display with the Action Bar | ||
| */ | ||
| export class ActionBar extends SpectrumElement { | ||
| export class ActionBar extends SizedMixin( | ||
| FocusVisiblePolyfillMixin(SpectrumElement) |
There was a problem hiding this comment.
Seems reasonable for the close button. Would be great if UXP prioritized adding this, as I'm sure there are lots of little places where UI like this falls through the cracks and keeping the polyfill code for something that has been fixed in browser for so long is questionable on our end.
Westbrook
changed the title
For older browser and UXP, we have to rely on focus-visible polyfill to match behaviour with the modern browser where the corresponding pseud-oselector is supported.
Westbrook
force-pushed
the
inasirhussain/actionbar-focus-visible-fix
branch
from
bdc141a
to
5c5171e
Compare
Westbrook
reviewed
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For older browser and UXP, we have to rely on focus-visible polyfill to match behaviour with the modern browser where the corresponding pseudo-selector is supported.
Related issue(s)
fixes #4279
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.