New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles,theme): add S2 tokens and theme #4241
base: main
Are you sure you want to change the base?
Conversation
… into jnjosh/theming-systems
…ctrum-web-components into jnjosh/theming-systems
Good start! Let's also think about creating some documentation around this in parallel! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for resolving the VRT's
@TarunAdobe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these tests and also the dev mode warning for spectrum-two
.
@@ -110,6 +115,7 @@ | |||
"@spectrum-css/commons": "^9.1.3", | |||
"@spectrum-css/expressvars": "^3.0.9", | |||
"@spectrum-css/tokens": "^13.2.0", | |||
"@spectrum-css/tokens-v2": "npm:@spectrum-css/tokens@^14.0.0-next.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is now a "stable" 14.0
release, should CSS get you a new "future" release with that info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a import for spectrum-two. I think the stable 14.0
version is importing S1 tokens
26ec02c
to
2c5c4a6
Compare
038816e
to
33c5c24
Compare
Introduce
spectrum-two
styles as a SWC theme.Description
Todos:
tokens-v2
from the@spectrum-css
'snext
versions.spectrum-two
theme that takes v2 tokens.spectrum-two
theme.spectrum-two
theme.Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.