-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated accessibility section #4161
base: main
Are you sure you want to change the base?
Changes from 2 commits
c7ba118
d7d546a
47804e1
0de30ba
2959d1c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
<div class="headerContainer"> | ||
<h2 id="accessibility" tabindex="-1" class="spectrum-Heading spectrum-Heading--sizeM">Accessibility testing status <sp-link class="header-anchor" href="#accessibility" aria-label="Accessibility" dir="ltr" focusable="">#</sp-link></h2> | ||
<sp-divider size="l" dir="ltr" role="separator"></sp-divider> | ||
</div> | ||
<sp-table quiet> | ||
<sp-table-head> | ||
<sp-table-head-cell>Component</sp-table-head-cell> | ||
<sp-table-head-cell>Accessibility test</sp-table-head-cell> | ||
<sp-table-head-cell>Accessibility Contract</sp-table-head-cell> | ||
<sp-table-head-cell>Status</sp-table-head-cell> | ||
</sp-table-head> | ||
<sp-table-body> | ||
<sp-table-row value="row1"> | ||
<sp-table-cell><sp-link href="https://opensource.adobe.com/spectrum-web-components/components/{{componentName}}/#usage">{{componentName}}</sp-link></sp-table-cell> | ||
<sp-table-cell> | ||
Default state | ||
</sp-table-cell> | ||
<sp-table-cell>Test(s) that ensure the initial render state of a component is accessible.</sp-table-cell> | ||
<sp-table-cell> | ||
<sp-badge variant="positive" id="trigger-1"> | ||
Tested | ||
</sp-badge> | ||
<sp-overlay trigger="trigger-1@hover" placement="bottom"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm seeing this work with a pointing device, but still not seeing this relationship managed in a screen reader. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. True since this is being triggered from an unaccessible component i.e |
||
<sp-tooltip> | ||
Passes all automated tests with no reported accessibility violations. | ||
</sp-tooltip> | ||
</sp-overlay> | ||
</sp-table-cell> | ||
</sp-table-row> | ||
<sp-table-row value="row2"> | ||
<sp-table-cell></sp-table-cell> | ||
<sp-table-cell> | ||
Advanced states | ||
</sp-table-cell> | ||
<sp-table-cell> | ||
Tests that ensure additional states of the component are accessible. | ||
This could be interactive states of a component or its multiple variants. | ||
</sp-table-cell> | ||
<sp-table-cell><sp-badge variant="positive" id="trigger-2">Tested</sp-badge> | ||
<sp-overlay trigger="trigger-2@hover" placement="bottom"> | ||
<sp-tooltip> | ||
Passes all automated tests with no reported accessibility violations. | ||
</sp-tooltip> | ||
</sp-overlay> | ||
</sp-table-cell> | ||
</sp-table-row> | ||
<sp-table-row value="row2"> | ||
<sp-table-cell></sp-table-cell> | ||
<sp-table-cell> | ||
Keyboard navigation | ||
</sp-table-cell> | ||
<sp-table-cell> | ||
Tests that ensure focus is properly managed, and all interactive functions of a component have a proper keyboard-accessible equivalent. | ||
</sp-table-cell> | ||
<sp-table-cell><sp-badge variant="positive" id="trigger-3">Tested</sp-badge> | ||
<sp-overlay trigger="trigger-3@hover" placement="bottom"> | ||
<sp-tooltip> | ||
Passes all automated tests with no reported accessibility violations. | ||
</sp-tooltip> | ||
</sp-overlay> | ||
</sp-table-cell> | ||
</sp-table-row> | ||
<sp-table-row value="row3"> | ||
<sp-table-cell></sp-table-cell> | ||
<sp-table-cell> | ||
Screen reader | ||
</sp-table-cell> | ||
<sp-table-cell> | ||
This manual testing ensures that the visual information on the screen | ||
is properly conveyed and read correctly by screen readers such as JAWS, VoiceOver, and NVDA.</sp-table-cell> | ||
<sp-table-cell> | ||
<sp-badge variant="indigo" id="trigger-4">Manually tested</sp-badge> | ||
<sp-overlay trigger="trigger-4@hover" placement="bottom"> | ||
<sp-tooltip> | ||
A human has manually tested this component, e.g. screen reader testing. | ||
</sp-tooltip> | ||
</sp-overlay> | ||
</sp-table-cell> | ||
</sp-table-row> | ||
</sp-table-body> | ||
</sp-table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly better positioning, but it still displays on both tabs, is that intended? It's also outside of the
<main>
element which means it's in a weird part of the document, semantically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been changed to a more controlled logic.