-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toast): Toast should have API for overriding the icon's alt text #4159
Open
susmithayenugula
wants to merge
9
commits into
main
Choose a base branch
from
yenugula/3406-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Mar 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fd0b6a4 - Browse repository at this point
Copy the full SHA fd0b6a4View commit details
Commits on Mar 7, 2024
-
fix(Toast): adding label for icon
Susmitha Yenugula committedMar 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 5fe626c - Browse repository at this point
Copy the full SHA 5fe626cView commit details
Commits on Mar 8, 2024
-
fix(toast): making label customizable on storybook
Susmitha Yenugula committedMar 8, 2024 Configuration menu - View commit details
-
Copy full SHA for c4cdb8c - Browse repository at this point
Copy the full SHA c4cdb8cView commit details -
Susmitha Yenugula committed
Mar 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 7f4b08e - Browse repository at this point
Copy the full SHA 7f4b08eView commit details -
fix(toast): remove incorrect test
Susmitha Yenugula committedMar 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 3051037 - Browse repository at this point
Copy the full SHA 3051037View commit details -
fix(toast): update unit tests and add default label
Susmitha Yenugula committedMar 8, 2024 Configuration menu - View commit details
-
Copy full SHA for aef34dc - Browse repository at this point
Copy the full SHA aef34dcView commit details
Commits on Mar 15, 2024
-
Merge branch 'main' of https://github.com/adobe/spectrum-web-components…
… into yenugula/3406-fix
Rajdeep Chandra committedMar 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 913d15e - Browse repository at this point
Copy the full SHA 913d15eView commit details -
fix(toast): updated type in test
Rajdeep Chandra committedMar 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 99bf2ff - Browse repository at this point
Copy the full SHA 99bf2ffView commit details
Commits on Mar 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ddb7b5 - Browse repository at this point
Copy the full SHA 1ddb7b5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.