Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use latest Spectrum CSS dependencies #3637

Merged
merged 4 commits into from Sep 13, 2023
Merged

chore: use latest Spectrum CSS dependencies #3637

merged 4 commits into from Sep 13, 2023

Conversation

Westbrook
Copy link
Collaborator

Description

Related issue(s)

Types of changes

  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link

Branch Preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited

Tachometer results

Chrome

accordion permalink

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 347.91ms - 361.65ms - unsure 🔍
-2% - +3%
-8.59ms - +9.58ms
branch 401 kB 348.33ms - 360.23ms unsure 🔍
-3% - +2%
-9.58ms - +8.59ms		 -

action-bar permalink

Version Bytes Avg Time vs remote vs branch
npm latest 476 kB 162.49ms - 168.42ms - unsure 🔍
-1% - +4%
-2.39ms - +6.19ms
branch 471 kB 160.45ms - 166.66ms unsure 🔍
-4% - +1%
-6.19ms - +2.39ms		 -

action-button permalink

Version Bytes Avg Time vs remote vs branch
npm latest 506 kB 297.28ms - 306.03ms - slower ❌
2% - 7%
6.34ms - 20.90ms
branch 501 kB 282.22ms - 293.85ms faster ✔
2% - 7%
6.34ms - 20.90ms		 -

action-group permalink

Version Bytes Avg Time vs remote vs branch
npm latest 527 kB 178.63ms - 184.48ms - unsure 🔍
-2% - +3%
-4.11ms - +4.74ms
branch 522 kB 177.92ms - 184.57ms unsure 🔍
-3% - +2%
-4.74ms - +4.11ms		 -

action-menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 624 kB 316.17ms - 328.12ms - unsure 🔍
-4% - +0%
-14.00ms - +1.38ms
branch 624 kB 323.61ms - 333.30ms unsure 🔍
-0% - +4%
-1.38ms - +14.00ms		 -
Firefox

accordion permalink

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 545.48ms - 578.28ms - unsure 🔍
-4% - +4%
-21.91ms - +22.31ms
branch 401 kB 546.85ms - 576.51ms unsure 🔍
-4% - +4%
-22.31ms - +21.91ms		 -

action-bar permalink

Version Bytes Avg Time vs remote vs branch
npm latest 476 kB 346.32ms - 375.64ms - unsure 🔍
-2% - +8%
-5.66ms - +27.26ms
branch 471 kB 342.70ms - 357.66ms unsure 🔍
-7% - +1%
-27.26ms - +5.66ms		 -

action-button permalink

Version Bytes Avg Time vs remote vs branch
npm latest 506 kB 494.30ms - 519.06ms - unsure 🔍
-5% - +1%
-26.53ms - +7.05ms
branch 501 kB 505.08ms - 527.76ms unsure 🔍
-1% - +5%
-7.05ms - +26.53ms		 -

action-group permalink

Version Bytes Avg Time vs remote vs branch
npm latest 527 kB 329.23ms - 351.73ms - unsure 🔍
-4% - +5%
-14.70ms - +17.38ms
branch 522 kB 327.71ms - 350.57ms unsure 🔍
-5% - +4%
-17.38ms - +14.70ms		 -

action-menu permalink

Version Bytes Avg Time vs remote vs branch
npm latest 624 kB 473.13ms - 503.35ms - faster ✔
1% - 9%
5.37ms - 46.83ms
branch 624 kB 500.15ms - 528.53ms slower ❌
1% - 10%
5.37ms - 46.83ms		 -

This was referenced Sep 12, 2023
Closed
Closed
@Westbrook Westbrook changed the title Spectrum CSS Upgrades chore: use latest Spectrum CSS dependencies Sep 13, 2023
hunterloftis
hunterloftis approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@hunterloftis hunterloftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0️⃣ days since we've shifted the vertical alignment of text 😁

@Westbrook Westbrook merged commit 5285475 into main Sep 13, 2023
47 checks passed
@Westbrook Westbrook deleted the spectrum-css branch September 13, 2023 15:54
@pfulton
Copy link
Collaborator

pfulton commented Sep 13, 2023

@hunterloftis don't we know it 😅 ! We are currently testing out an updated version of Adobe Clean that will HOPEFULLY fix these types of problems once and for all. Keep an 👀 out for that, coming (hopefully soon) to a repo near you!

@hunterloftis
Copy link
Contributor

@pfulton awesome, & good luck!

TarunAdobe pushed a commit that referenced this pull request Sep 20, 2023
@Westbrook @TarunAdobe
chore: use latest Spectrum CSS dependencies (#3637)
cb257e8 
* chore: use latest non-breaking CSS dependencies

* ci: update golden images cache

* chore: use latest breaking CSS dependencies

* ci: update golden images cache
TarunAdobe pushed a commit that referenced this pull request Sep 21, 2023
@Westbrook @TarunAdobe
chore: use latest Spectrum CSS dependencies (#3637)
d755f0f 
* chore: use latest non-breaking CSS dependencies

* ci: update golden images cache

* chore: use latest breaking CSS dependencies

* ci: update golden images cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterloftis hunterloftis hunterloftis approved these changes

@pfulton pfulton Awaiting requested review from pfulton

@Rajdeepc Rajdeepc Awaiting requested review from Rajdeepc

@blunteshwar blunteshwar Awaiting requested review from blunteshwar

@najikahalsema najikahalsema Awaiting requested review from najikahalsema

@TarunAdobe TarunAdobe Awaiting requested review from TarunAdobe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Westbrook @pfulton @hunterloftis