Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lit to v3 #3773

Closed
1 task done
damooo opened this issue Nov 6, 2023 · 3 comments · Fixed by #4292
Closed
1 task done

Update lit to v3 #3773

damooo opened this issue Nov 6, 2023 · 3 comments · Fixed by #4292
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@damooo
Copy link

damooo commented Nov 6, 2023

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

All

Description of the requested feature

Lit is updated to v3. There are not many breaking changes. It will be great if swc update the dependency too. Otherwise bundler seems including both versions, and types are incompatible when used along with new lit versions, and other ecosystem components.

Mockups or screenshots

No response

Implementation notes or ideas

No response

@damooo damooo added enhancement New feature or request triage An issue needing triage labels Nov 6, 2023
@Westbrook
Copy link
Collaborator

We are tracking this in #3209, but it will likely still be a little while yet before we are able to release fully lit@3.0 versions of the library. Depending on install order and package manager configurations, there should be no issue in using our components in a lit@3.0 application. You will need to have both versions in your build, but in terms of client side libraries is quite a small price to pay. I can say that you won't be able to force the next version (via resolutions or overrides) without issue today, but maybe there's an interim step that we could do to unlock that in the time being.

@damooo
Copy link
Author

damooo commented Nov 6, 2023

I can say that you won't be able to force the next version (via resolutions or overrides) without issue today, but maybe there's an interim step that we could do to unlock that in the time being.

As update being already worked upon, it is not an issue to include both versions now. And also no particular other urgent reason to override. swc seems re-exporting lit functionalities. I would be importing them, as we are anyway using SpectrumElement as baseclass.

@Westbrook
Copy link
Collaborator

It shouldn't be an issue to include both versions.

In face, if you're always importing through SWC then you'll always get v2, which means you wouldn't really be using two versions!

@najikahalsema najikahalsema added dependencies Pull requests that update a dependency file and removed triage An issue needing triage labels Nov 16, 2023
@Westbrook Westbrook mentioned this issue Mar 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
3 participants