Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Focus-ring does not get shown on sp-action-bar's sp-close-button when keyboard focus is brought on the sp-action-bar #4279

Closed
1 task done
inasirhussain opened this issue Apr 17, 2024 · 1 comment · Fixed by #4273
Closed
1 task done

[Bug]: Focus-ring does not get shown on sp-action-bar's sp-close-button when keyboard focus is brought on the sp-action-bar #4279

inasirhussain opened this issue Apr 17, 2024 · 1 comment · Fixed by #4273
Labels
bug Something isn't working Component: Action Bar triage An issue needing triage

Comments

@inasirhussain
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-action-bar

Expected behavior

This is an issue in sp-action-bar component that it does not extends sp-action-bar class properly to leverage focus-visible polyfill for the browser which do not support :focus-visible pseudo-class inherently.

Actual behavior

Focus-ring does not get shown on sp-action-bar's sp-close-button

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response
@inasirhussain inasirhussain added bug Something isn't working triage An issue needing triage labels Apr 17, 2024
@inasirhussain inasirhussain mentioned this issue Apr 17, 2024
Merged
13 tasks
@Westbrook
Copy link
Collaborator

As we continue to look at changes specifically for supporting the UXP environment, can you think of any automated testing approaches that we could use to support ensuring continued support of this handicapped context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Component: Action Bar triage An issue needing triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(action-bar): include focus-visible polyfilling inasirhussain/spectrum-web-components
3 participants
@Westbrook @najikahalsema @inasirhussain