Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix loglevel error message when running prettier commands #2756

Merged
merged 1 commit into from
May 14, 2024

Conversation

castastrophe
Copy link
Collaborator

Description

When running the format command, a notice would show up in the console log noting that the flag should be log-level and not loglevel. This PR corrects that typo.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • yarn formatter actionbutton: expect to see no warnings in the log about the log-level flag

To-do list

@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels May 13, 2024
Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: 37f5a0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 13, 2024

🚀 Deployed on https://pr-2756--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented May 13, 2024

File metrics

Summary

Total size: 4.48 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe self-assigned this May 14, 2024
@castastrophe castastrophe added the size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. label May 14, 2024
@jawinn jawinn self-requested a review May 14, 2024 14:16
Copy link
Collaborator

@jawinn jawinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The warning has gone away.

To confirm the old and new behavior, I needed to add the --verbose flag in order to see warnings when running the formatter: yarn formatter actionbutton --verbose.

@castastrophe castastrophe force-pushed the chore-prettier-loglevel-error-message branch from 20bda58 to c2c75ee Compare May 14, 2024 15:35
@castastrophe castastrophe enabled auto-merge (squash) May 14, 2024 15:35
@castastrophe castastrophe force-pushed the chore-prettier-loglevel-error-message branch from c2c75ee to 37f5a0b Compare May 14, 2024 15:42
@castastrophe castastrophe merged commit 57a07eb into main May 14, 2024
16 of 22 checks passed
@castastrophe castastrophe deleted the chore-prettier-loglevel-error-message branch May 14, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants