feat: define missing color property in some components #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f9def6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jawinn
force-pushed
the
jawinn/css-731-missing-color-definitions
branch
from
97e0784
to
10974f2
Compare
|
🚀 Deployed on https://pr-2754--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.48 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsdatepicker
radio
slider
splitview
treeview
well
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
Use typography template in Meter storybook. Helps make sure that color is set on this heading without coming from higher up in the DOM, and completes code TODO item.
During the work to create a single entry point for PostCSS, it was discovered that parts of several components did not define a color, and instead relied on a color being set higher up in the DOM. This update sets a color on some of these and adds mods where necessary.
jawinn
force-pushed
the
jawinn/css-731-missing-color-definitions
branch
from
10974f2
to
7f9def6
Compare
castastrophe
approved these changes
May 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the
colorproperty in parts of some components that were relying on inheriting a color from higher up in the DOM. These affected components were noticed in VRTs during the work to create a single entry point for PostCSS. The following has been updated:spectrum-heading-colortoken per design guidance. Adds a new property.The Jira issue and VRT also listed the icon component, but that one has been left as is. Its color is intentionally set to
inheritby default.CSS-731
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Expected VRT differences:
spectrum-body-color.Regression testing
Validate:
To-do list