feat(tokens): add spectrum and express to tokens package #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 170fb3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Deployed on https://pr-2742--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.64 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailstokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
feat-s1-express-assets-to-tokens
branch
from
697435f
to
c82818b
Compare
castastrophe
force-pushed
the
feat-s1-express-assets-to-tokens
branch
5 times, most recently
from
08529db
to
754d5b0
Compare
castastrophe
commented
May 9, 2024
pfulton
approved these changes
May 9, 2024
castastrophe
force-pushed
the
feat-s1-express-assets-to-tokens
branch
3 times, most recently
from
96c2ce5
to
4078e32
Compare
castastrophe
force-pushed
the
feat-s1-express-assets-to-tokens
branch
from
4078e32
to
92f5e39
Compare
castastrophe
force-pushed
the
feat-s1-express-assets-to-tokens
branch
3 times, most recently
from
45cebeb
to
c916451
Compare
castastrophe
force-pushed
the
feat-s1-express-assets-to-tokens
branch
from
c916451
to
170fb3e
Compare
|
SWC branch: adobe/spectrum-web-components#4442 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for our migration to a Spectrum 2-focused project, this PR adds component-specific theme assets to our token package. In this way, we are connecting the system overrides with a particular version of the token system (namely S1). When S1 content is removed, this will include removing the system theming approach entirely. By loading the theme and bridge assets for your component, you will be able to support S1 and S2 in parallel if you so wish (note that for this to work, you will still have to load both the S1 and S2 releases of the @spectrum-css/tokens package in tandem and with appropriate scoping).
In this PR we are adding 3 addition steps to our build process for only those components that support system theming:
<component-name>/themes/spectrum.cssoutput totokens/components/spectrum/<component-name>.css<component-name>/themes/express.cssoutput totokens/components/express/<component-name>.css<component-name>/index.csswith areferencesOnly = trueflag for the Splintinator postcss plugin to output a new asset:tokens/components/bridge/<component-name>.csswhich will contain the mapping of component-specific custom properties to their--systemprefixed pairing. This allows S2 base CSS to continue to work with S1 tokens (until a time that a new breaking change is released for that component).How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list