🚨 DO NOT MERGE 🚨 - feat(tokens)!: Migrate to Spectrum 2 "foundations" #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pfulton
added
wip
pfulton
changed the title
|
🚀 Deployed on https://pr-2713--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.47 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsassetcard
card
dial
modal
page
site
slider
splitview
table
tokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
Rajdeepc
reviewed
Apr 30, 2024
| @@ -120,7 +120,7 @@ governing permissions and limitations under the License. | |||
| ); | |||
|
|
|||
| /* Divider */ | |||
| --spectrum-accordion-divider-color: var(--spectrum-gray-300); | |||
| --spectrum-accordion-divider-color: var(--spectrum-gray-200); | |||
There was a problem hiding this comment.
In the context of upgrade this make sense, but is there a direction forward given --spectrum-accordion-divider-color will be referenced in both S1 and S2 in swc? Won't this be a custom DIY token rather?
There was a problem hiding this comment.
(cc: @jnjosh) This is a good call-out, and just one example of a place where this will likely need to be addressed.
pfulton
force-pushed
the
s2-foundations
branch
2 times, most recently
from
17e47b1
to
f8c4972
Compare
BREAKING CHANGE: migrates Spectrum CSS to Spectrum 2
Migrates any instance of `--spectrum-gray-50` to use `--spectrum-gray-25` as per the S2 migration guide
Migrates usages of `--spectrum-gray-75` to use `--spectrum-gray-50` as per the s2 migration guide.
Migrates usages of `--spectrum-gray-100` to use `--spectrum-gray-75` as per the s2 migration guide
Migrates usages of `--spectrum-gray-200` to use `--spectrum-gray-100` as per the s2 migration guide
Migrates usages of `--spectrum-gray-300` to use `spectrum-gray-200` as per the s2 migration guide
castastrophe
force-pushed
the
s2-foundations
branch
from
9374b63
to
6280e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 DO NOT MERGE
Spectrum 2 Foundations
darkesttheme deprecated and removed;lightanddarkare the two color "themes" in S2expressremoved--spectrum-gray-50->--spectrum-gray-25--spectrum-gray-75->--spectrum-gray-50--spectrum-gray-100->--spectrum-gray-75--spectrum-gray-200->--spectrum-gray-100--spectrum-gray-300->--spectrum-gray-200I'm going to try to keep my commits logically separated so that this work is a little less taxing to review. I'd suggest that reviewers look commit-by-commit at the changes rather than referring to the "files changed" diffs.
If this branch becomes too difficult to manage before we merge, we can look for opportunities to squash some commits (the grays migrations are probably good candidates for this)
Description
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list