-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(picker): migrate to spectrum 2 #2697
base: spectrum-two
Are you sure you want to change the base?
Commits on May 15, 2024
-
feat(picker): spectrum 2 migration
- Integrate themes CSS files into index.css - Corrects the chevron icon size being shown for each size in storybook - Uses new S2 tokens for field width and corner rounding
Configuration menu - View commit details
-
Copy full SHA for 35cf31b - Browse repository at this point
Copy the full SHA 35cf31bView commit details -
feat(picker): storybook - expanded and improved chromatic template
Expands the Chromatic-only template in Storybook to increase coverage of different options. Organizes the stories into sections using the formatting and typography previously established with Action button. States in each section are based on the grid of options in the Desktop S2 design Figma, with some additions such as the loading state. And the Switch examples from the existing template. Removes the "Open" story which is now covered in the Chromatic template. Improves display of Popover within these different contexts; fixes how it is aligned on the side label example. Changes the side label example to use flex row instead of using inline-block which could wrap as the screen shrunk. Adds aria-labelledby and unique ids to make sure the label is associated with the Picker. Adds missing icon (to left of value/placeholder text) option to Storybook, along with VRT coverage.
Configuration menu - View commit details
-
Copy full SHA for b137924 - Browse repository at this point
Copy the full SHA b137924View commit details -
fix(picker): use correct colors on hover of disabled state
Fixes several problems with colors not matching the spec, caused by a few specificity issues. Some disabled states were showing changing colors on hover. Resolved with some added specificity to a disabled selector and excluding disabled from the is-open styles.
Configuration menu - View commit details
-
Copy full SHA for 2618a97 - Browse repository at this point
Copy the full SHA 2618a97View commit details -
Add new down state using "calculated perspective" method, and existing custom properties that define the width and height.
Configuration menu - View commit details
-
Copy full SHA for 26ac516 - Browse repository at this point
Copy the full SHA 26ac516View commit details -
chore(picker): clear up linter warnings
Clear up linter warnings. Removes an unused custom property.
Configuration menu - View commit details
-
Copy full SHA for 5ea4408 - Browse repository at this point
Copy the full SHA 5ea4408View commit details -
build(picker): use beta version of commons dependency
Since the commons version on main was updated to 10.0, the Picker started building with the wrong version of commons when importing basebutton.css and listing mods that have been removed in the version of commons in the spectrum-two branch.
Configuration menu - View commit details
-
Copy full SHA for bd88882 - Browse repository at this point
Copy the full SHA bd88882View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff65d2b - Browse repository at this point
Copy the full SHA ff65d2bView commit details -
fix(picker): high contrast loading hover and disabled down state
Fixes the loading state in high contrast not showing the disabled chevron color on hover, and disables the down state on disabled and loading. Some added specificity was necessary.
Configuration menu - View commit details
-
Copy full SHA for c508ed1 - Browse repository at this point
Copy the full SHA c508ed1View commit details -
fix(picker): use correct spacing between icons and value text
The spacing between alert icon and disclosure icon was incorrect because it was being overridden by a selector that shouldn't have been affecting this scenario (which was using the subsequent-sibling combinator ~). Some mods around the spacing for the three different types of icons were also not working as expected. Fixes this spacing and clarifies which spacing is which. Renames the mod that applies to the optional workflow icon to the left of the value. Simplifies quiet styles by changing custom property values instead of adding extra styles.
Configuration menu - View commit details
-
Copy full SHA for 21c5d9b - Browse repository at this point
Copy the full SHA 21c5d9bView commit details -
docs(picker): include text overflow and quiet sizing in vrts
Adds example with overflow behavior in Chromatic only template, so this is captured in VRTs. Also adds Sizing + quiet section, and passes through isDisabled to the Help text.
Configuration menu - View commit details
-
Copy full SHA for 609b0da - Browse repository at this point
Copy the full SHA 609b0daView commit details -
feat(picker): add support for cjk line-height
Adds the CJK line-height token defined on the design specs.
Configuration menu - View commit details
-
Copy full SHA for 6907bb8 - Browse repository at this point
Copy the full SHA 6907bb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 952fcf2 - Browse repository at this point
Copy the full SHA 952fcf2View commit details -
feat(picker): top to alert icon token change
The top to alert icon in Spectrum 2 now uses the component-top-to-workflow-icon-* tokens as defined on the design.
Configuration menu - View commit details
-
Copy full SHA for 5a2c61a - Browse repository at this point
Copy the full SHA 5a2c61aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11e98db - Browse repository at this point
Copy the full SHA 11e98dbView commit details -
docs(picker): adjust helptext wrapper and add conditional controls
Adjusts Picker Storybook markup for the example of using HelpText alongside the Picker. - Makes sure HelpText appears below the Picker when using side label - HelpText now gets set to the same t-shirt size as the Picker Adds conditional controls to disabled and loading states, per the PR feedback that disabled + loading should not be possible as a combination.
Configuration menu - View commit details
-
Copy full SHA for e5e7450 - Browse repository at this point
Copy the full SHA e5e7450View commit details -
feat(picker): include downstate dimension capture
Include downstate dimension capture in Storybook. Removes fallback experiment from downstate tokens in the CSS, as they do not work when the inline-size or block-size token or mod gets set to auto or 100%.
Configuration menu - View commit details
-
Copy full SHA for 27e5907 - Browse repository at this point
Copy the full SHA 27e5907View commit details
Commits on May 28, 2024
-
docs(picker): popover should not show when open
Per design feedback, the popover should not be showing when the picker is in the loading state. This updates the Storybook template.
Configuration menu - View commit details
-
Copy full SHA for 1b9a3ff - Browse repository at this point
Copy the full SHA 1b9a3ffView commit details