New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: storybook description format; lit syntax alignment #2681
Conversation
|
7e6ecf8
to
41625fc
Compare
🚀 Deployed on https://pr-2681--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.57 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
efcfabd
to
8aab4f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, and I think it's a step in the right direction, as we continue to bring over some of the features of the Docs site.
It looks like we might have lost the padding on some of the stories (see the Chromatic diffs; Action Menu is an example). In the Card stories, we seem to be missing the ...
icon (also captured via Chromatic).
Overall, it looks like this batch of Chromatic diffs has mostly detected things that I think we should try to address before we merge this work in.
6e2b1db
to
f9d2a3a
Compare
@pfulton Great feedback. I found a decorators typo in several stories and corrected a few issues. There are 5 baselines left that I think are improvements and fixes. Let me know if you find any other issues! |
ac7d58b
to
f7a7cf0
Compare
f7a7cf0
to
f18dfe2
Compare
Description
Descriptions can be written as JDoc comments in Storybook stories above stories, meta, or components. This format seems more contributor-friendly than attaching
parameters.docs.description.{story,component}
to each story. These JSDoc blocks can include markdown as well!This PR moves all description data into JSDoc blocks. It also updates customStyles objects to use a consistent format and naming approach along with a few other minor linting fixes.
In an effort to prevent unnecessary VRT shifts, I also migrated all
ems
andrems
used in displaying VRT groupings topx
.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
yarn start
) or preview the linked version in the PR.Regression testing
Validate:
Screenshots
To-do list