Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: internal workspace links #2677

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: internal workspace links #2677

wants to merge 1 commit into from

Conversation

castastrophe
Copy link
Collaborator

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe added the skip_vrt Add to a PR to skip running VRT (but still pass the action) label Apr 19, 2024
@castastrophe castastrophe self-assigned this Apr 19, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2024 •
edited

⚠️ No Changeset found

Latest commit: d3524bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited

File metrics

Summary

Total size: 4.48 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited

🚀 Deployed on https://pr-2677--spectrum-css.netlify.app

@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch 2 times, most recently from b6e3cb9 to 0d8f403 Compare April 24, 2024 14:22
@castastrophe
Copy link
Collaborator Author

Note to self: I need to validate that workspace is replaced during a changeset release

@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch 2 times, most recently from a3d768e to 97e5393 Compare April 26, 2024 22:04
@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch from 97e5393 to d3524bf Compare May 7, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@castastrophe castastrophe

Labels
skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@castastrophe