Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor fixes in build workflow and package alignment #2672

Merged
merged 1 commit into from May 14, 2024

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Apr 18, 2024

Description

  • Add the guides folder to the storybook dependencies and include mdx assets as well
  • Use a shared list of storybook dependencies called "tools" instead of redefining them in every tasks inputs
  • Remove the manual ui-icons build task from the storybook build and start tasks and the site build task
  • Remove the manual token build from the shared build task
  • Add ui-icons to the default yarn builder and leverage the shared build task in subsequent commands

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link
Contributor

github-actions bot commented Apr 18, 2024

🚀 Deployed on https://pr-2672--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Apr 18, 2024

File metrics

Summary

Total size: 4.48 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the chore-build-workflow-fixes branch 2 times, most recently from 7409af7 to 3454405 Compare April 18, 2024 20:23
Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: 18db80e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe self-assigned this Apr 24, 2024
@castastrophe castastrophe added build Issues associated with the build process; often a refactor run_vrt For use on PRs looking to kick off VRT labels Apr 24, 2024
@castastrophe castastrophe marked this pull request as ready for review April 24, 2024 14:40
@castastrophe castastrophe force-pushed the chore-build-workflow-fixes branch 3 times, most recently from 33f6ed3 to efda356 Compare April 26, 2024 22:24
@castastrophe castastrophe changed the title chore: minor fixes in build workflow chore: minor fixes in build workflow and package alignment May 3, 2024
@castastrophe castastrophe force-pushed the chore-build-workflow-fixes branch 2 times, most recently from 64b56e2 to 7616666 Compare May 13, 2024 21:17
Copy link
Collaborator

@mdt2 mdt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, saw no regressions and was able to run install, clean, build, start, and dev.

@castastrophe castastrophe enabled auto-merge (squash) May 14, 2024 15:38
@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-to-merge and removed run_vrt For use on PRs looking to kick off VRT ready-for-review labels May 14, 2024
@castastrophe castastrophe merged commit 041c0cc into main May 14, 2024
11 checks passed
@castastrophe castastrophe deleted the chore-build-workflow-fixes branch May 14, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues associated with the build process; often a refactor ready-to-merge skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants