feat(progressbar): s2 migration #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdt2
commented
Apr 12, 2024
| @@ -53,7 +53,7 @@ export const withContextWrapper = makeDecorator({ | |||
| // Change background color when demonstrating static color options. | |||
| if (args.staticColor === "black") { | |||
| container.style.background = "var(--spectrum-examples-gradient-static-black)"; | |||
| } else if (args.staticColor === "white") { | |||
| } else if (args.staticColor === "white" || args.isStaticWhite === "true") { | |||
There was a problem hiding this comment.
In the case of Progress Bar, only Static White is supported. I didn't want to make folks use a dropdown in the Storybook controls when there's only one option, so I expanded this to accommodate for isStaticWhite as a boolean option.
|
🚀 Deployed on https://pr-2659--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.32 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsprogressbar
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
jawinn
requested changes
Apr 15, 2024
rise-erpelding
approved these changes
Apr 15, 2024
jawinn
approved these changes
Apr 16, 2024
mdt2
force-pushed
the
mdt2/css-711-s2-progress-bar
branch
from
6b74834
to
55fb881
Compare
pfulton
force-pushed
the
spectrum-two
branch
2 times, most recently
from
f3dd9ff
to
9931a8e
Compare
castastrophe
force-pushed
the
spectrum-two
branch
5 times, most recently
from
6dbc850
to
ae7aedd
Compare
mdt2
force-pushed
the
mdt2/css-711-s2-progress-bar
branch
from
b037ee9
to
92b9f11
Compare
🦋 Changeset detectedLatest commit: 5f582df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mdt2
force-pushed
the
mdt2/css-711-s2-progress-bar
branch
2 times, most recently
from
7d5bcfb
to
53917df
Compare
mdt2
force-pushed
the
mdt2/css-711-s2-progress-bar
branch
from
53917df
to
5f582df
Compare
Merged
pfulton
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates Progress Bar to Spectrum 2 (design spec). Includes:
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
@jawinn
Regression testing
Validate:
To-do list