Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alertbanner): migrate to spectrum 2 #2652

Draft
wants to merge 4 commits into
base: spectrum-two
Choose a base branch
from

Commits on May 16, 2024

  1. feat(alertbanner): start migration to spectrum two

    Migrates the component to spectrum two.
    - Theme files are removed, and their custom properties integrated into
      the main index.css.
    - Renames misspelled mod custom property (noted in docs)
    - Simplifies background color styles by changing a single custom
      property per variant, as done on other components.
    jawinn committed May 16, 2024
    Configuration menu
    Copy the full SHA
    967ea5b View commit details
    Browse the repository at this point in the history
  2. feat(alertbanner): spectrum 2 spacing and mod name cleanup

    Adjust some spacings to match the Spectrum 2 spec spacing.
    And renames some mods so they are more consistent with current naming
    conventions, and their purpose is more clear.
    
    === Update spacing to match the Spectrum 2 spec ===
    
    One issue with the S1 version was that there was too much space between
    the text and the button, when the button wrapped to the next line. And
    there was a different token defined for the space from the bottom edge
    to the text, and vertically between the button and the text.
    
    This helps resolve this by moving some of the spacing to padding on the
    AlertBanner-body, and subtracting this value from some of the other
    custom properties. Along with using both column-gap and row-gap
    properties.
    
    === adjust storybook template spacing and decorator ===
    
    Improves spacing in Storybook template, especially the Chromatic only
    template. Decorator and wrapper styles are modeled after those used in
    Action button, so they look more similar. Previously the layout was a
    little cramped and the "detail" elements were missing their margins
    because they were display inline.
    jawinn committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5e92f83 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. docs(alertbanner): custom storybook docs page and template updates

    Creates a custom MDX docs page in Storybook for the Alert banner
    component. And reworks the stories and chromatic-only templates a little
    to facilitate and increase coverage.
    
    Includes Storybook VRT coverage for the max width changes in PR #2762 .
    Tests the display of the alert banner when in a container larger than
    and smaller than its max-inline-size.
    jawinn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    89e5832 View commit details
    Browse the repository at this point in the history
  2. chore(alertbanner): linter updates and update mods

    - Add stylelint disable line comments for some false positives caught by
      the linter.
    - Re-generate mods file
    jawinn committed May 17, 2024
    Configuration menu
    Copy the full SHA
    031d8a9 View commit details
    Browse the repository at this point in the history